fix: metrics.json could use more data - #722
Conversation
Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
Hi @Mr-Neutr0n thanks for the contribution! I didn't look deeply into it yet, but doesn't it overlap with |
|
Thanks for checking. metrics_by_type remains the per-requirement link coverage map, while needs_overview adds total, local versus external, and per-type counts across all needs, including non-requirement types, so the two sections serve different purposes. The current ECA failure is a legal-agreement gate rather than a code or test failure, so it needs to be resolved through the Eclipse contributor process. |
|
I think here, we have to figure out what That is our bad @Mr-Neutr0n , we will clarify this and come back once we have an answer. |
|
Hi @MaximilianSoerenPollak - no rush at all; just checking whether the "more data" definition landed on your side. Happy to pick this back up whenever you have an answer, and fine to close if it is no longer a priority. |
Fixes #685
Added a small, documented
needs_overview(total/external/local/by_type) to the generic metrics.json, updated its JSON schema, added tests, and documented it — the issue's guidance (no arbitrary data, hard to remove fields) was treated as instruction, not followed literally into an arbitrary dump.Could not run the suite locally: /config/init.py:2234. Fork CI needs a maintainer approval to run, so this branch has no test signal yet.
This change was prepared with AI assistance under human direction and review.